Re: [PATCH v1 2/2] drm/xe/mcu_i2c: Take over control of the controller enabling

[Andy Shevchenko]

On Tue, Jun 23, 2026 at 04:58:39PM +0200, Raag Jadav wrote:
> On Tue, Jun 23, 2026 at 01:56:53PM +0300, Andy Shevchenko wrote:
> > On Mon, Jun 22, 2026 at 01:47:59PM +0200, Heikki Krogerus wrote:

...

> > > +#define IC_CON				0x00
> > > +#define IC_TAR				0x04
> > > +#define IC_SAR				0x08
> > > +#define IC_ENABLE			0x6c
> > > +#define IC_ENABLE_STATUS		0x9c
> > 
> > Heh, I would like to have a shared header with the registers, but dunno
> > if the prons will weight out the cons.
> 
> Perhaps something like i2c-algo-pca.h?

It's different. It's more device specific header and it doesn't look like
a platform data. For SPI PXA2xx we have them in pxa2xx_ssp.h. And we have
some device specific i2c headers, seems like the pattern is
*_i2c.h, exempli gratia, designware_i2c.h.

-- 
With Best Regards,
Andy Shevchenko