Re: [PATCH v2 0/1] watchdog: realtek-otto: Make use of regmap API

[Guenter Roeck]

On 6/20/26 04:23, Rustam Adilov wrote:
> Hello,
>
> I have noticed the status for this patch series is "Changes Requested"
> in the patchwork site but the maintainer opposes the requested changes
> by Sander in [1], so what do i do here? It is just one the roadblocks
> to get USB stuff supported for Realtek chips.
>
> I have already sent a reply week later in [2] but didn't get a response
> back. Maybe this email could be served as a gentle remainder.

I said:
	So this is now a NACK if unnecessary error handling is indeed added,
	unless someone convinces me that this would add some benefits that I
	am unable to see.

Your response did not explain the benefits of adding the unnecessary error
handling. I did not see a rationale from Sander either.

On top of that, your patch did not explain the real reason for the patch,
as stated in your reply. This means that, for me, it was just a patch making
no functional changes for no good reason other than to potentially _increase_
code complexity by adding unnecessary error handling while at the same time
claiming that code complexity would be reduced.

Also, I do not recall even an attempt to address (or even comment on) the
actual problem with the driver as reported by Sashiko.

Guenter

> [1] - https://lore.kernel.org/linux-watchdog/1d5091ff-e497-4b5a-a906-7cc02c31c4c0@xxxxxxxxxxxx/
> [2] - https://lore.kernel.org/linux-watchdog/b4b09be5ff456a23d15a5af3237b9b46@xxxxxxxxxxx/
>
> Best,
> Rustam