Re: [PATCH v3 3/3] iio: magnetometer: add driver for QST QMC5883L Sensor

From: Jonathan Cameron

Date: Tue Jun 23 2026 - 15:21:08 EST


On Fri, 19 Jun 2026 16:45:06 +0600
Siratul Islam <siratul.islam@xxxxxxxxx> wrote:

> Add driver for the QST QMC5883L 3-Axis Magnetic Sensor
> connected via i2c.
>
> Signed-off-by: Siratul Islam <siratul.islam@xxxxxxxxx>

I'm going to apply this now but given rc1 is still some way off plenty
of time for more feedback or tags!

Applied to the testing branch of iio.git with a tiny tweak.

Thanks,

Jonathan

> diff --git a/drivers/iio/magnetometer/qmc5883l.c b/drivers/iio/magnetometer/qmc5883l.c
> new file mode 100644
> index 000000000000..b7fff3b63ca4
> --- /dev/null
> +++ b/drivers/iio/magnetometer/qmc5883l.c
> @@ -0,0 +1,517 @@
> +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +/*
> + * Support for QST QMC5883L 3-Axis Magnetic Sensor on I2C bus.
> + *
> + * Copyright (C) 2026 Siratul Islam <siratul.islam@xxxxxxxxx>
> + *
> + * Datasheet available at
> + * <https://www.qstcorp.com/upload/pdf/202512/13-52-04%20QMC5883L%20Datasheet%20Rev.%20B.pdf>
> + *
My pet trivial complaint. Blank line adds nothing useful. I'll remove it whilst applying ;)
> + */