Re: [PATCH v2 4/5] iio: adc: ti-adc161s626: log buffer setup failure in probe
From: Andy Shevchenko
Date: Tue Jun 23 2026 - 15:55:43 EST
On Tue, Jun 23, 2026 at 08:36:36PM +0100, Jonathan Cameron wrote:
> On Sat, 20 Jun 2026 23:10:56 +0530
> Prashant Rahul <prashantrahul23@xxxxxxxxx> wrote:
>
> > Errors are logged when enabling the regulator or adding the cleanup
> > action fails, but not when buffer setup fails. Log the error returned by
> > the buffer setup path as well.
> Why this particular one but not the devm_iio_device_register() below it?
> Both pretty much only fail on driver bugs. Or out of memory for
> which dev_err_probe() doesn't print anything anyway (on basis that
> is normally pretty noisy).
For the record, I need to withdraw my tag as I haven't noticed that this series
just adds tons of dead code (based on -ENOMEM returned value).
--
With Best Regards,
Andy Shevchenko