Re: [PATCH] net: ipa: fix SMEM state handle leaks in SMP2P init
From: Jakub Kicinski
Date: Tue Jun 23 2026 - 17:06:41 EST
On Tue, 23 Jun 2026 10:53:49 -0500 Alex Elder wrote:
> So I guess they were never "put" before?
>
> This looks OK, but I'll just mention that the IPA code
> doesn't use devm_*() (managed) interfaces. So it would
> be more consistent to just call qcom_smem_state_put()
> at the end of ipa_smp2p_exit() for both ipa->enabled_state
> and ipa->valid_state.
Let's do that instead. The devm_ APIs prevent about as many bugs
as they cause.