RE: [PATCH 2/3] dt-bindings: hwmon: pmbus: Support for onsemi's FD5121

[Selvamani Rajagopal]

> -----Original Message-----
> From: Conor Dooley <conor@xxxxxxxxxx>
> Subject: Re: [PATCH 2/3] dt-bindings: hwmon: pmbus: Support for onsemi's FD5121
> 
>
> > +
> > +title: onsemi's multi-phase digital controllers
> 
> Can someone explain to me what a "digital controller" actually is?
> Seems very generi and that a word may have been left out, were it not
> for the fact that this wording is used several times in the patch.
> 

Thanks for reviewing.

According to me, "digital controller" means the controller uses digital circuits to implement 
the features and functionality. We can remove "digital" and keep only controller. It won't make any
difference for Linux documentation.

> > +
> > + enum:
> > + - onnn,fd5121
> > + - onnn,fd5123
> > + - onnn,fd5125
> 
> Your /OF/ match data in your driver suggests that you intended to permit
> fallback compatibles here?

Agree. Sorry about the discrepancy. Will fix it.

> 
> |+#ifdef CONFIG_OF
> |+static const struct of_device_id fd5121_of_match[] = {
> |+ { .compatible = "onnn,fd5121" },
> |+ { }
> |+};
> |+MODULE_DEVICE_TABLE(of, fd5121_of_match);
> |+#endif
>