Re: [PATCH v2 4/4] panic: avoid duplicate all CPU backtraces from sys_info

[Feng Tang]

On Tue, Jun 23, 2026 at 03:35:01PM +0000, Bradley Morgan wrote:
> panic_other_cpus_shutdown() handles SYS_INFO_ALL_BT before stopping the
> other CPUs. Do not ask sys_info() to handle that bit again later in the
> panic path.
> 
> Use sys_info_without_all_bt() so panic_print=all_bt does not request more
> output after the CPUs are stopped.

Good catch! Thanks!

Later in panic_other_cpus_shutdown(), it sends IPIs to stop other CPUs, and
this patch does avoid dumping local call trace again!

For the whole serie, feel free to add:

Reviewed-by: Feng Tang <feng.tang@xxxxxxxxxxxxxxxxx>

Thanks,
Feng

> 
> Fixes: b76e89e50fc3 ("panic: generalize panic_print's function to show sys info")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Bradley Morgan <include@xxxxxxxxx>
> ---
> Changes since v1:
> - New patch using the same helper for panic.
> 
>  kernel/panic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/panic.c b/kernel/panic.c
> index d030f88ad4ef..2cf229c7c0cf 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -683,7 +683,7 @@ void vpanic(const char *fmt, va_list args)
>  	 */
>  	atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
>  
> -	sys_info(panic_print);
> +	sys_info_without_all_bt(panic_print);
>  
>  	kmsg_dump_desc(KMSG_DUMP_PANIC, buf);
>  
> -- 
> 2.53.0