Re: [PATCH] fpga: stratix10-soc: Fix SVC mailbox handling during reconfiguration
From: NG, TZE YEE
Date: Tue Jun 23 2026 - 23:21:05 EST
On 24/6/2026 12:09 am, Dinh Nguyen wrote:
>
>
> On 6/23/26 04:47, tze.yee.ng@xxxxxxxxxx wrote:
>> From: Tien Sung Ang <tien.sung.ang@xxxxxxxxxx>
>>
>> Fix incorrect stratix10_svc_done() usage during FPGA reconfiguration.
>
> Do you need a Fixes tag and Cc: stable then?
>
Yes. The incorrect stratix10_svc_done() call in write_init() has been
there since the driver was first added. I'll add the following fixes tag
in v2:
Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")
Cc: stable@xxxxxxxxxxxxxxx # 5.1+
>>
>> Do not call stratix10_svc_done() at the end of write_init() on
>> success, so
>> the SVC session remains active through write() and write_complete(). Call
>> stratix10_svc_done() on failure in write_init() and write() so the shared
>> SVC mailbox is released when reconfiguration aborts, allowing coexistence
>> with other SVC clients such as soc64-hwmon.
>>
>