Re: [PATCH] thunderbolt: xdomain: notify peers after enumeration

[Mika Westerberg]

Hi,

On Wed, Jun 24, 2026 at 09:11:31AM +0800, Rqirus wrote:
> Service drivers may register local XDomain properties while discovery is
> still in progress. This can cause the properties changed notification to be
> sent before the peer is ready to act on it.
> 
> If the peer has already read the local property block before the service
> was registered, it may keep using the old property generation and miss the
> newly registered service. With ThunderboltIP this can leave the network
> service half-discovered after a warm reboot and the login request
> eventually times out.
> 
> Queue another properties changed notification after the XDomain reaches
> ENUMERATED so the peer can re-read the final local properties.
> 
> Signed-off-by: Rqirus <cmh79479@xxxxxxxxx>

You should be using your full name here.

The patch itself looks reasonable to me.

> ---
>  drivers/thunderbolt/xdomain.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thunderbolt/xdomain.c b/drivers/thunderbolt/xdomain.c
> index 86b2f7474..9c068d073 100644
> --- a/drivers/thunderbolt/xdomain.c
> +++ b/drivers/thunderbolt/xdomain.c
> @@ -1811,6 +1811,7 @@ static void tb_xdomain_state_work(struct work_struct *work)
>  			tb_xdomain_failed(xd);
>  		} else {
>  			xd->state = XDOMAIN_STATE_ENUMERATED;
> +			tb_xdomain_queue_properties_changed(xd);
>  		}
>  		break;
>  
> 
> base-commit: 502d801f0ab03e4f32f9a33d203154ce84887921
> -- 
> 2.47.3