Re: [PATCH v2] staging: most: dim2: use dev_err_probe() for clock errors in rcar enable functions

[Dan Carpenter]

On Tue, Jun 23, 2026 at 03:35:08PM +0300, Batu Ada Tutkun wrote:
> rcar_gen2_enable() and rcar_gen3_enable() use the old pattern of
> dev_err() followed by return PTR_ERR() when devm_clk_get() fails.
> fsl_mx6_enable() in the same file was already converted to use
> dev_err_probe() by a previous cleanup series.
> 
> Convert the remaining two functions for consistency. devm_clk_get()
> calls clk_get() which can return -EPROBE_DEFER if the clock provider
> has not yet registered. Using dev_err_probe() suppresses the log at
> error level in that case, avoiding misleading "cannot get clock" output
> during a normal deferred probe.
> 
> clk_prepare_enable() cannot return -EPROBE_DEFER since the clock handle
> is already acquired at that point, so those error paths are left as
> dev_err().
> 
> Signed-off-by: Batu Ada Tutkun <batuadatutkun@xxxxxxxxx>
> 
> ---
> Compile tested only. No R-Car hardware available. This is a correctness
> fix for the deferred probe path, not a response to a reported
> user visible issue.
> 
> Changes in v2:
> - Mention clk_get() explicitly in commit message
> - Add testing note under --- cut off line
> 

Perfect.  Thanks.

Reviewed-by: Dan Carpenter <error27@xxxxxxxxx>

regards,
dan carpenter