Re: [PATCH] i2c: qup: Propagate clock enable failures
From: Konrad Dybcio
Date: Wed Jun 24 2026 - 03:48:02 EST
On 6/24/26 7:52 AM, Pengpeng Hou wrote:
> The QUP I2C driver treats the core and iface clocks as required
> resources, but qup_i2c_enable_clocks() ignores clk_prepare_enable()
> failures. Probe can then continue to register the I2C adapter, and
> runtime/system resume can return success, even when a required clock
> transition failed.
>
> Make the helper return an error, unwind a partially enabled clock, and
> propagate failures from probe and resume paths.
>
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad