Re: [PATCH v5 3/3] media: i2c: imx471: Add Sony IMX471 image sensor driver

[Kate Hsuan]

Hi Tarang,

Thank you for reviewing.

On Wed, Jun 24, 2026 at 4:43 PM Tarang Raval
<tarang.raval@xxxxxxxxxxxxxxxxx> wrote:
>
> Hi Kate,
>
> > Add a new driver for Sony imx471 camera sensor. It is based on
> > Jimmy Su <jimmy.su@xxxxxxxxx> implementation and the driver can be found
> > in the following URL.
> > https://github.com/intel/ipu6-drivers/commits/master/drivers/media/i2c/imx471.c
> >
> > This sensor can be found on Lenovo X1 Carbon G14, X9-14 and X9-15 laptops
> > and it is a part of IPU7 solution. The driver was tested on Lenovo X1
> > Carbon G14, X9-14 and X9-15 laptops.
> >
> > Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx>
> > ---
>
> ...
>
> > +static const char * const imx471_supply_name[] = {
> > +       "avdd",
> > +};
>
> As we discussed in the last revision, this should be "vana" instead of "avdd".
> Better to use the regulator name as defined in the datasheet.

"avdd" is exposed by INT3472. If it was changed to "vana", the driver complained
[  205.839599] imx471 i2c-SONY471A:00: supply vana not found, using
dummy regulator
[  205.854821] imx471 i2c-SONY471A:00: Error reading reg 0x0016: -121
[  205.854830] imx471 i2c-SONY471A:00: error -EREMOTEIO: failed to read chip id
[  205.854834] imx471 i2c-SONY471A:00: error -EREMOTEIO: failed to
find sensor: -121
[  205.855354] imx471 i2c-SONY471A:00: probe with driver imx471 failed
with error -121

So, avdd is necessary.

>
> Other than that, the driver looks good to me.
>
> Reviewed-by: Tarang Raval <tarang.raval@xxxxxxxxxxxxxxxxx>
>
> Best Regards,
> Tarang
>


-- 
BR,
Kate