Re: [PATCH v3 5/5] ASoC: Intel: atom: Use guard() for locking

[Bui Duc Phuc]

On Wed, Jun 24, 2026 at 3:54 PM Cezary Rojewski
<cezary.rojewski@xxxxxxxxx> wrote:
>
> On 6/24/2026 10:07 AM, Bui Duc Phuc wrote:
> > Thanks for the review.
> >
> >>> Clean up the code using guard() for spin & mutex locks.
> >>> Merely code refactoring, and no behavior change.
> >>
> >> The change looks good - just dropping by to mention that the cleanup.h
> >> is missing everywhere : )
> >
> > I noticed that both spinlock.h and mutex.h already pull in cleanup.h,
> > so the guard()/scoped_guard() macros are available without an explicit include.
> > Could you clarify the reasoning for adding #include <linux/cleanup.h>
> > explicitly here?
>
> Follow the include-what-you-use (IWYU) approach.  While the approach
> could be tailored per-header, in general it makes any future job of
> cleaning up the headers easier.

Thanks for the clarification.
I will explicitly add #include <linux/cleanup.h> to follow the IWYU
principle in the next version.