Re: [PATCH 1/2] arm64: dts: qcom: sm8250-xiaomi-elish: Add pm8008 PMIC

[Konrad Dybcio]

On 6/22/26 8:07 PM, Xin Xu wrote:
> On Mon, 2026-06-22 at 13:40 +0200, Konrad Dybcio wrote:
>> On 6/19/26 6:07 PM, Xin Xu wrote:
>>> Add the pm8008 PMIC node on i2c15 with seven LDOs,
>>> using GPIO84 as interrupt and GPIO76 as reset.
>>>
>>> Signed-off-by: Xin Xu <xxsemail@xxxxxx>
>>> ---

[...]

>>> +	pm8008_default: pm8008-default-state {
>>> +		int-pins {
>>> +			pins = "gpio84";
>>> +			function = "gpio";
>>> +			bias-disable;
>>> +			drive-strength = <2>;
>>> +			input-enable;
>>> +		};
>>> +
>>> +		reset-pins {
>>> +			pins = "gpio76";
>>> +			function = "gpio";
>>> +			bias-pull-up;
>>> +			drive-strength = <2>;
>>> +			output-high;
>>
>> Drop output-high, the driver will take care of setting the output
>> state
>>
>> Konrad
> 
> Thank you for your review!
> 
> I will fix the coding style issues (blank line before status,
> interrupts-extended, property order, and dropping output-high)
> in the next version.
> 
> I have verified all LDO voltages against the downstream device tree:
> https://github.com/MiCode/kernel_devicetree/tree/elish-r-oss/
> The definitions can be found around lines 209–244 in
> qcom/elish-sm8250-camera-board.dtsi

Thanks. It's best if you grab the DTB from a running device (which
has all the overlays applied etc.), which you can grab from
/sys/firmware/fdt

You can then pass that to DTC directly

Konrad