Re: [PATCH 2/2] arm64: dts: socfpga: agilex7-gen2: Add initial device tree

[Nazle Asmade, Muhammad Nazim Amirul]

On 24/6/2026 6:26 pm, Krzysztof Kozlowski wrote:
> On 24/06/2026 12:17, Nazle Asmade, Muhammad Nazim Amirul wrote:
>>> SoC without any interface, serial or storage or network, is close to
>>> useless one.
>>>
>>> I don't see a point in having it in mainline. Serial is usually ABSOLUTE
>>> minimum.
>>>
>>> Best regards,
>>> Krzysztof
>>>
>> Hi Krzysztof,
>>
>> Thank you for the review and fast response!
>>
>> I ran both dt_binding_check and dtbs_check (with CHECK_DTBS=y) locally —
>> both passed without errors. Could you clarify which specific test you
>> believe is failing?
> 
> I would expect simple-bus schema warning or W=1, because node is placed
> outside of soc@, but maybe there is no such.
 > >>
>> Regarding "MMIO goes to MMIO" — are you referring to the GIC
> 
> Comments are placed in very specific and intentional place. Please read
> guides how mailing list in-line review works before posting patches.
Apologies on this matter.>
>> (interrupt-controller@7000000) being placed at the root level instead of
>> under the soc bus node?
>>
>> Regarding the serial console — the platform clock driver is not yet
>> upstream, so the UART depends on clkmgr. Would adding the UART with
>> clock-frequency be acceptable as an interim solution?
> 
> Add complete working serial. Why can't you use fixed placeholder clock?
> There are probably multiple ways to solve it, not necessary
> clock-frequency and I do not even remember if clock-frequency is allowed.
Will add a UART node with a fixed-clock placeholder>
> But if you cannot bring serial, then my comment stays valid: this is
> unusable upstream thus is not ready to be posted and merged.
> 
> Best regards,
> Krzysztof
Sorry I had to reply again to this thread due to not including all 
recipient just now. Also one thing to mention, this patch actually a V1 
version and latest should be v2 but it is just a device renaming change 
on the latest one so the comment still valid. Will send out v3 once it 
is ready! Thanks Krzysztof!

BR,
Nazim