Re: [PATCH net] tipc: fix out-of-bounds read in broadcast Gap ACK blocks
From: Sam P
Date: Wed Jun 24 2026 - 08:45:25 EST
On 24/06/2026 13:56, Tung Quang Nguyen wrote:
This is wrong because the skb is not dropped as it should be.
Note that 'ga' is NULL just for legacy TIPC that does not support Selective ACK.
To correctly fix this issue, you need to set a flag (for example, a Boolean output parameter) to TRUE instead of 'ga=NULL'.
Then, immediately return and repeatedly pass the flag to tipc_rcv() in order to drop the skb.
Thanks for the feedback! I'll address it in a v2.