Re: [PATCH v2] mfd: ls2kbmc: mfd: ls2kbmc: Fix iomem pointer handling in video mode parsing

[Huacai Chen]

Reviewed-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>

On Wed, Jun 24, 2026 at 4:56 PM Binbin Zhou <zhoubinbin@xxxxxxxxxxx> wrote:
>
> Use pointers annotated with the __iomem marker for all iomem map calls,
> and creates a local copy of the mapped IO memory for future access in
> the code. memcpy_fromio() and memcpy_toio() are used to read/write data
> from/to mapped IO memory
>
> Fixes: 0d64f6d1ffe9 ("mfd: ls2kbmc: Introduce Loongson-2K BMC core driver")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202603021730.Yy3QXYTw-lkp@xxxxxxxxx/
> Closes: https://lore.kernel.org/oe-kbuild-all/202606120639.WG6eb8VU-lkp@xxxxxxxxx/
> Signed-off-by: Binbin Zhou <zhoubinbin@xxxxxxxxxxx>
> ---
> V2:
>  - Add the missing memcpy_fromio();
>  - Drop the unnecessary `buf` variable.
>
> Link to V1:
> https://lore.kernel.org/all/20260616115530.4012675-1-zhoubinbin@xxxxxxxxxxx/
>
>  drivers/mfd/ls2k-bmc-core.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/ls2k-bmc-core.c b/drivers/mfd/ls2k-bmc-core.c
> index 408056bfb2fe..1312812860c0 100644
> --- a/drivers/mfd/ls2k-bmc-core.c
> +++ b/drivers/mfd/ls2k-bmc-core.c
> @@ -427,14 +427,20 @@ static int ls2k_bmc_init(struct ls2k_bmc_ddata *ddata)
>   */
>  static int ls2k_bmc_parse_mode(struct pci_dev *pdev, struct simplefb_platform_data *pd)
>  {
> -       char *mode;
> +       char *mode __free(kfree) = NULL;
> +       void __iomem *base;
>         int depth, ret;
>
>         /* The last 16M of PCI BAR0 is used to store the resolution string. */
> -       mode = devm_ioremap(&pdev->dev, pci_resource_start(pdev, 0) + SZ_16M, SZ_16M);
> +       base = devm_ioremap(&pdev->dev, pci_resource_start(pdev, 0) + SZ_16M, SZ_16M);
> +       if (!base)
> +               return -ENOMEM;
> +
> +       mode = kmalloc(SZ_16M, GFP_KERNEL);
>         if (!mode)
>                 return -ENOMEM;
>
> +       memcpy_fromio(mode, base, SZ_16M);
>         /* The resolution field starts with the flag "video=". */
>         if (!strncmp(mode, "video=", 6))
>                 mode = mode + 6;
>
> base-commit: c454531af72e0df811600601413bb8d3d039ed08
> --
> 2.52.0
>