Re: [PATCH v1 11/13] iio: Initialize spi_device_id arrays using member names
From: Jonathan Cameron
Date: Wed Jun 24 2026 - 13:53:19 EST
On Fri, 19 Jun 2026 22:19:50 +0200
Linus Walleij <linusw@xxxxxxxxxx> wrote:
> On Fri, Jun 19, 2026 at 5:55 PM Uwe Kleine-König (The Capable Hub)
> <u.kleine-koenig@xxxxxxxxxxxx> wrote:
>
> > While being less compact, using named initializers allows to more easily
> > see which members of the structs are assigned which value without having
> > to lookup the declaration of the struct. And it's also more robust
> > against changes to the struct definition.
> >
> > The mentioned robustness is relevant for a planned change to struct
> > spi_device_id that replaces .driver_data by an anonymous union.
> >
> > This patch doesn't modify the compiled arrays, only their representation
> > in source form benefits. The former was confirmed with x86 and arm64
> > builds.
> >
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>
>
> Acked-by: Linus Walleij <linusw@xxxxxxxxxx>
>
> Yours,
> Linus Walleij
Applied. Thanks!
J