Re: [PATCH] sh: Use generic OHCI platform provider symbol

From: Geert Uytterhoeven

Date: Wed Jun 24 2026 - 14:16:38 EST


On Wed, 24 Jun 2026 at 19:56, Pengpeng Hou <pengpeng@xxxxxxxxxxx> wrote:
> The old SuperH-specific `USB_OHCI_SH` provider symbol no longer carries
> an OHCI provider object. The current platform OHCI provider is
> `USB_OHCI_HCD_PLATFORM`, which builds ohci-platform.o.
>
> Several SH CPU subtypes still select `USB_OHCI_SH`, and the
> sh7757lcr defconfig still enables it directly. Switch both the subtype
> selects and the defconfig to `USB_OHCI_HCD_PLATFORM` so the intended OHCI
> provider remains reachable when `USB_OHCI_HCD` is enabled.
>
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>

Fixes: 4f6dfc2136fb2e8d ("usb: remove the dead USB_OHCI_SH option")
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

It's a pity people sometimes don't take into account review comments
before applying patches...
https://lore.kernel.org/CAMuHMdVM3BpvVD3c4gp1OidnwF5zFd4MJecij7zWBnahzNaSNw@xxxxxxxxxxxxxx/

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds