Re: [PATCH v3 3/3] KVM: arm64: top up stage 2 memcache for dirty logging faults

From: Marc Zyngier

Date: Wed Jun 24 2026 - 14:25:18 EST


On Wed, 24 Jun 2026 18:46:10 +0100,
Bradley Morgan <include@xxxxxxxxx> wrote:
>
> On June 24, 2026 6:39:16 PM GMT+01:00, Bradley Morgan <include@xxxxxxxxx>
> wrote:
> >
> >Note: Patch 3 seems to conflict because of patch 2 (the comments)
> >
> >
> >Oops! :(
> >
> >V4 (after people have their review go), will contain one commit (patch
> >3) with the updated comments.
> >
> >Patch 1 and 2 applies as usual.
> >
> >Apologies for my messup.
> >
> >Thanks!
>
>
> Actually. Hmm.
>
> I'll just drop patches 2 and 3, I'll do them at a later date, please
> disregard patches 2 and 3, patch 1 doesn't rely on 2 and 3..
>
> If you guys wanna have a look feel free! :)

As I suggested in my reply to your hasty v2, taking a few *days*
between versions is generally a good thing. it gives the reviewers
time to chime in, and gives you the opportunity to reflect on what
you've just written (reading your own patches after a few days is a
sure way to go and rewrite them).

Actually, by posting more often, you are guaranteeing that people
*avoid* reviewing your stuff, since odds are that there is a new
version coming in the next 10 minutes, so why bother...

But hey, that's free advice, so it's probably worthless.

M.

--
Without deviation from the norm, progress is not possible.