Re: [PATCH 1/2] iio: dac: dac8163: Add driver for DAC8163

[Andy Shevchenko]

On Wed, Jun 24, 2026 at 04:47:00PM +0200, Lukas wrote:
> On Tue, Jun 23, 2026 at 10:39:23PM +0300, Andy Shevchenko wrote:
> 
> > > +		dev_dbg(dev, "%s: val=%d val2=%d\n", __func__, val, val2);
> > 
> > No. Is it RFC? PoC? Or production-ready? If not the latter, come when it will
> > be production-ready.
> 
> I will remove the debug print. I tried my best to make this driver production-ready.
> I saw that other drivers also have similar debug messages so i didnt
> remove it after my first tests and thought it is ok to leave it in
> there.

Debug messages are different. And in IIO we don't have them (perhaps some
historical leftovers or corner cases, dunno). If you have an example, share
the pointer, I will check that. Perhaps we can drop them in that driver.
(The debug prints like above are fine in the drivers in staging, but staging
 is not really accepting much nowadays, so it's not the point.)

> My intention was to try to apply the suggestions and comments i
> get and send a second revision. Do you think thats the right way?

That's the way how it goes. You address all or almost all comments,
send a new version where in the comments you need to explain the
non-addressed pieces ("why?" they haven't been addressed).

-- 
With Best Regards,
Andy Shevchenko