Re: [PATCH v5 1/3] dt-bindings: iio: health: add adi,max86150

[Krzysztof Kozlowski]

On Tue, Jun 23, 2026 at 11:11:21PM +0300, Md Shofiqul Islam wrote:

Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830

> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +    description: |

Do not need '|' unless you need to preserve formatting.

> +      Active-low interrupt line.  Asserted when the FIFO almost-full
> +      threshold is reached or when a new PPG sample is ready.
> +
> +  vdd-supply:

vdddig? Which supply is this?

> +    description: Digital core power supply (1.8 V).
> +
> +  avdd-supply:

I cannot find it in datasheet.

> +    description: Analog core power supply (1.8 V).
> +
> +  vref-supply:
> +    description: ECG reference voltage supply.
> +
> +  leds-supply:

Datasheet calls this VLED. Don't invent names.

Best regards,
Krzysztof