Re: [PATCH 0/3] iio: light: al3xxx: add missing REGMAP_I2C to Kconfig entries

[Joshua Crofts]

On Thu, 25 Jun 2026 09:41:31 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:

> On Thu, Jun 25, 2026 at 07:20:42AM +0200, Joshua Crofts wrote:
> > This series adds REGMAP_I2C support to three AL3xxx ambient light
> > sensors that were previously missing this dependency, causing build
> > failures.  
> 
> There are two problems with the commit message:
> - SELECT versus select (see the comment against patch 1)
> - you mentioned build failures but haven't provided any evidence, please
> provide a reasonable lines of build output to prove that
> 

Sure, I could elaborate a bit more.

Just run `make allnoconfig` and `make menuconfig` in which you select
IIO, I2C and any AL3xxx sensor and `make .` will fail with errors such as

drivers/iio/light/al3010.c: In function ‘al3010_probe’:
drivers/iio/light/al3010.c:185:24: error: implicit declaration of function ‘devm_regmap_init_i2c’ [-Wimplicit-function-declaration]
  185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
      |                        ^~~~~~~~~~~~~~~~~~~~
drivers/iio/light/al3010.c:185:22: error: assignment to ‘struct regmap *’ from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
  185 |         data->regmap = devm_regmap_init_i2c(client, &al3010_regmap_config);
      |                      ^
drivers/iio/light/al3010.c: At top level:
drivers/iio/light/al3010.c:48:35: error: storage size of ‘al3010_regmap_config’ isn’t known
   48 | static const struct regmap_config al3010_regmap_config = {
      |                                   ^~~~~~~~~~~~~~~~~~~~

Hopefully this is enough.

-- 
Kind regards

CJD