Re: [PATCH 1/7] dt-bindings: adm1275: ROHM BD12780 hot-swap controller

[Matti Vaittinen]

I think I (almost) missed this review... Sorry for the belated reply.

On 17/06/2026 13:28, Krzysztof Kozlowski wrote:
> On Tue, Jun 16, 2026 at 09:35:35AM +0300, Matti Vaittinen wrote:
>   +
> > +  Datasheets:
> > +    https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/power_switch/bd12780muv-lb-e.pdf
> > +    https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/power_switch/bd12780amuv-lb-e.pdf
> > +
> >   properties:
> >     compatible:
> > -    enum:
> > -      - adi,adm1075
> > -      - adi,adm1272
> > -      - adi,adm1273
> > -      - adi,adm1275
> > -      - adi,adm1276
> > -      - adi,adm1278
> > -      - adi,adm1281
> > -      - adi,adm1293
> > -      - adi,adm1294
> > -      - silergy,mc09c
> > +    oneOf:
> > +      - items:
> > +          enum:
>
>
> s/items/enum/, so:
>
> oneOf:
>    - enum:
>    ....

Thanks Krzysztof. I am always so lost with these bindings. Giving the 
concrete suggestion(s) helps a lot!

> > +            - adi,adm1075
> > +            - adi,adm1272
> > +            - adi,adm1273
> > +            - adi,adm1275
> > +            - adi,adm1276
> > +            - adi,adm1278
> > +            - adi,adm1281
> > +            - adi,adm1293
> > +            - adi,adm1294
> > +            - rohm,bd12780
> > +            - silergy,mc09c
> > +
> > +# Require BD12780 as a fall-back for BD12780A.
>
> No need for the comment, schema is quite explicit.

Eh... I know it is explicit for one who fluently reads yaml. Not all of 
us do that :| (See my reply to the previous comment...) I am not sure 
the comment hurts - while I am sure it helps occasional binding reader 
like me. Can you please reconsider keeping the comment?

Although, I am not sure if Guenter suggested me to drop the compatible 
for the bd12780a and only use the bd12780 - or if his comment only 
applied to the i2c IDs.

https://lore.kernel.org/all/751cd5eb-104f-4445-a6d2-8119ad5d5660@xxxxxxxxxxxx/

Well, I will keep the bd12780a compatible and drop the I2C ID unless 
something else is suggested. Again, the BD12780 and BD12780A do have 
different hardware properties (at least in I2C slave address selection 
pins), and while it doesn't really matter for the Linux drivers, the DT 
bindings should ideally be generic and not Linux specific.

Yours,
	-- Matti.

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~