Re: [PATCH v2 1/2] dt-bindings: arm: qcom,coresight-tnoc: allow arm,primecell-periphid

[Jie Gan]

On 6/25/2026 3:24 PM, Krzysztof Kozlowski wrote:
> On Wed, Jun 24, 2026 at 05:49:25PM +0800, Jie Gan wrote:
> > The TNOC device is an AMBA primecell and may carry the standard
> > arm,primecell-periphid property, which is used to supply the
> > peripheral ID when it cannot be read from the device registers.
> >
> > Reference primecell.yaml and set additionalProperties to true so the
> > binding accepts arm,primecell-periphid along with the other common
> > primecell properties.
> >
> > Signed-off-by: Jie Gan <jie.gan@xxxxxxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml
> > index ef648a15b806..9624fc0adfdc 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-tnoc.yaml
> > @@ -32,6 +32,9 @@ select:
> >     required:
> >       - compatible
> >   
> > +allOf:
> > +  - $ref: /schemas/arm/primecell.yaml#
> > +
> >   properties:
> >     $nodename:
> >       pattern: "^tn(@[0-9a-f]+)$"
> > @@ -78,7 +81,7 @@ required:
> >     - in-ports
> >     - out-ports
> >   
> > -additionalProperties: false
> > +additionalProperties: true
>
> Nope, it is not allowed. Explicitly mentioned in writing bindings and
> all DT introductory talks by me.

Yes, I am totally wrong with this and I should add:
unevaluatedProperties: false

and remove
additionalProperties: false

Thanks,
Jie

> Best regards,
> Krzysztof