Re: [PATCH] staging: rtl8723bs: clean up style issues in rtl8723b_cmd.c

[Dan Carpenter]

On Wed, Jun 24, 2026 at 08:31:10PM +0100, Alonso Garrigues wrote:
> Split long do-while conditions across multiple lines and add spaces
> around binary operators. Fix indentation of misaligned comments.
> 

Fix one type of warning per patch and send it as a patchset.

> Signed-off-by: Alonso Garrigues <agarrigues@xxxxxxxxxx>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 39 +++++++++++++-------
>  1 file changed, 26 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> index c35c7f1c38ef..d31d8e445dcc 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> @@ -74,7 +74,7 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmd
>  		else {
>  			memcpy((u8 *)(&h2c_cmd)+1, pCmdBuffer, 3);
>  			memcpy((u8 *)(&h2c_cmd_ex), pCmdBuffer+3, CmdLen-3);
> -/* 			*(u8 *)(&h2c_cmd) |= BIT(7); */
> +			/* *(u8 *)(&h2c_cmd) |= BIT(7); */

Just delete this dead code.

>  		}
>  
>  		*(u8 *)(&h2c_cmd) |= ElementID;
> @@ -416,13 +416,14 @@ void rtl8723b_set_FwPwrMode_cmd(struct adapter *padapter, u8 psmode)
>  
>  		}
>  
> -/* offload to FW if fw version > v15.10
> -		pmlmeext->DrvBcnEarly = 0;
> -		pmlmeext->DrvBcnTimeOut =7;
> +		/* offload to FW if fw version > v15.10 */
> +		/* pmlmeext->DrvBcnEarly = 0; */
> +		/* pmlmeext->DrvBcnTimeOut =7; */

Dead code.  Delete.  Some other places as well.

regards,
dan carpenter