Re: [PATCH v3 2/8] irqchip/qcom-pdc: Move all statics to struct pdc_desc

[Maulik Shah (mkshah)]

On 6/17/2026 6:56 PM, Konrad Dybcio wrote:
> On 6/16/26 11:25 AM, Maulik Shah wrote:
>> There are multiple statics used. Move all to struct pdc_desc to better
>> align with versioning support. Document them.
>>
>> No functional impact.
>>
>> Signed-off-by: Maulik Shah <maulik.shah@xxxxxxxxxxxxxxxx>
>> ---
> 
> [...]
> 
>>  static void pdc_enable_intr(struct irq_data *d, bool on)
>>  {
>> -	unsigned long flags;
>> +	guard(raw_spinlock)(&pdc->lock);
> 
> tglx suggested to use guard(irq) around "the other callsite"..
> which I'm not sure where it'd be - maybe around __pdc_enable_intr()
> in pdc_setup_pin_mapping()?
> 
> Otherwise this patch looks good to me
> 
> Konrad

All callers will be from irqchip except pdc_setup_pin_mapping() which was
invoking lock-less because at that time irqchip is not setup and as such
can stay lock less.

Once the patch-3 of this series is applied pdc_setup_pin_mapping() too
will use the lock as it makes direct use of pdc->enable_intr() where the new lock
is kept (only for v2.7 version specific enable function).

Thanks,
Maulik