[PATCH] HID: usbhid: Use seq_buf_putc() in three functions
From: Markus Elfring
Date: Thu Jun 25 2026 - 05:23:39 EST
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 25 Jun 2026 11:11:26 +0200
A single space character should occasionally be put into a sequence buffer.
Thus use the function “seq_buf_putc” in these implementations.
The source code was transformed by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/hid/usbhid/hid-core.c | 2 +-
drivers/hid/usbhid/usbkbd.c | 2 +-
drivers/hid/usbhid/usbmouse.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 96b0181cf819..a755102b8cfe 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -1412,7 +1412,7 @@ static int usbhid_probe(struct usb_interface *intf, const struct usb_device_id *
if (dev->product) {
if (dev->manufacturer)
- seq_buf_puts(&hid_name, " ");
+ seq_buf_putc(&hid_name, ' ');
seq_buf_puts(&hid_name, dev->product);
}
diff --git a/drivers/hid/usbhid/usbkbd.c b/drivers/hid/usbhid/usbkbd.c
index 83d4df0d7a45..02abd54eca49 100644
--- a/drivers/hid/usbhid/usbkbd.c
+++ b/drivers/hid/usbhid/usbkbd.c
@@ -302,7 +302,7 @@ static int usb_kbd_probe(struct usb_interface *iface,
if (dev->product) {
if (dev->manufacturer)
- seq_buf_puts(&kbd_name, " ");
+ seq_buf_putc(&kbd_name, ' ');
seq_buf_puts(&kbd_name, dev->product);
}
diff --git a/drivers/hid/usbhid/usbmouse.c b/drivers/hid/usbhid/usbmouse.c
index b3b2abeee614..9fce51d65cd6 100644
--- a/drivers/hid/usbhid/usbmouse.c
+++ b/drivers/hid/usbhid/usbmouse.c
@@ -150,7 +150,7 @@ static int usb_mouse_probe(struct usb_interface *intf, const struct usb_device_i
if (dev->product) {
if (dev->manufacturer)
- seq_buf_puts(&mouse_name, " ");
+ seq_buf_putc(&mouse_name, ' ');
seq_buf_puts(&mouse_name, dev->product);
}
--
2.54.0