Re: [PATCH] i2c: qcom-cci: drop custom suspend/resume and rely on runtime PM helpers

[Loic Poulain]

On Thu, Jun 25, 2026 at 11:42 AM Wenmeng Liu
<wenmeng.liu@xxxxxxxxxxxxxxxx> wrote:
>
> cci_resume() unconditionally calls cci_resume_runtime() regardless of
> the runtime PM state.
>
> If the device is already runtime-suspended before system suspend,
> the clock is re-enabled while runtime_status remains RPM_SUSPENDED.
> As a result, pm_request_autosuspend() does not arm the timer,
> leaving the clock permanently enabled.
>
> Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Wenmeng Liu <wenmeng.liu@xxxxxxxxxxxxxxxx>

Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>

> ---
>  drivers/i2c/busses/i2c-qcom-cci.c | 18 +-----------------
>  1 file changed, 1 insertion(+), 17 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
> index 4d64895a9e9e4e0bd5e0ccb5c3cc04b282b1e4d5..bdeda3979c4814b5cdb463734b8361da7fffa879 100644
> --- a/drivers/i2c/busses/i2c-qcom-cci.c
> +++ b/drivers/i2c/busses/i2c-qcom-cci.c
> @@ -492,24 +492,8 @@ static int __maybe_unused cci_resume_runtime(struct device *dev)
>         return 0;
>  }
>
> -static int __maybe_unused cci_suspend(struct device *dev)
> -{
> -       if (!pm_runtime_suspended(dev))
> -               return cci_suspend_runtime(dev);
> -
> -       return 0;
> -}
> -
> -static int __maybe_unused cci_resume(struct device *dev)
> -{
> -       cci_resume_runtime(dev);
> -       pm_request_autosuspend(dev);
> -
> -       return 0;
> -}
> -
>  static const struct dev_pm_ops qcom_cci_pm = {
> -       SET_SYSTEM_SLEEP_PM_OPS(cci_suspend, cci_resume)
> +       SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
>         SET_RUNTIME_PM_OPS(cci_suspend_runtime, cci_resume_runtime, NULL)
>  };
>
>
> ---
> base-commit: 4e5dfb7c84012007c3c7061126491bbc92d71bf1
> change-id: 20260625-cci-3eedf766d43b
>
> Best regards,
> --
> Wenmeng Liu <wenmeng.liu@xxxxxxxxxxxxxxxx>
>