Re: [PATCH v2 2/2] arm64: dts: qcom: sm8250-xiaomi-elish: add ov8856 front camera

[Xin Xu]

On Wed, 2026-06-24 at 13:56 +0200, Konrad Dybcio wrote:
> On 6/22/26 8:52 PM, Xin Xu wrote:
> > Add the ov8856 front camera, connected on CCI1 to CSIPHY4 and
> > powered by pm8008 LDOs and other supplies.
> > 
> > Signed-off-by: Xin Xu <xxsemail@xxxxxx>
> > ---
> 
> [...]
> 
> >  &cdsp {
> >  	firmware-name = "qcom/sm8250/xiaomi/elish/cdsp.mbn";
> >  	status = "okay";
> > @@ -877,6 +933,20 @@ bt_en_state: bt-default-state {
> >  		bias-pull-up;
> >  	};
> >  
> > +	camera_front_active: camera-front-active-state {
> > +		pins = "gpio109";
> > +		function = "gpio";
> > +		bias-disable;
> > +		drive-strength = <2>;
> > +	};
> > +
> > +	mclk3_active: mclk3-active-state {
> > +		pins = "gpio97";
> > +		function = "cam_mclk";
> > +		bias-disable;
> > +		drive-strength = <4>;
> > +	};
> 
> nit: other nodes have drive-strength before bias-disable
> 
> Also let's move the mclk pin state definition to sm8250, it's not
> specific to this board
> 
> Konrad

I will fix the coding style issues in the next patch.
Also, in the next version of the series, the mclk pin state
will be applied to sm8250.dtsi in a separate patch.

Best regards,
Xin Xu