Re: [PATCH v1 4/8] arm64: dts: qcom: shikra: Add soundwire and macro nodes

[Konrad Dybcio]

On 6/16/26 10:13 PM, Mohammad Rafi Shaik wrote:
> Add SoC-level SoundWire masters and LPASS RX/VA macro nodes, along with
> DMIC and SWR pinctrl states required by the audio data path.
> 
> Keep these nodes disabled in shikra.dtsi so board dts files can selectively
> enable and configure them.
> 
> Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>
> ---

Just a couple style nits:

[...]

> +		rxmacro: codec@a040000 {
> +			compatible = "qcom,shikra-lpass-rx-macro";
> +			reg = <0x0 0x0a040000 0x0 0x1000>;
> +
> +			pinctrl-0 = <&rx_swr_active>;
> +			pinctrl-names = "default";

Let's move this down.. maybe above all the #cells

> +
> +			clocks = <&audiocorecc AUDIO_CORE_CC_RX_MCLK_CLK>,
> +				<&audiocorecc AUDIO_CORE_CC_RX_MCLK_2X_CLK>,

Please align all <s

> +				 <&vamacro>;
> +			clock-names = "mclk",
> +				      "npl",
> +				      "fsgen";
> +
> +			#clock-cells = <0>;
> +			clock-output-names = "mclk";
> +			#sound-dai-cells = <1>;
> +			status = "disabled";

Let's keep a \n before 'status', everywhere

Konrad