Re: [PATCH] block: partitions: Use seq_buf_putc() in cmdline_partition()
From: Markus Elfring
Date: Thu Jun 25 2026 - 08:19:37 EST
>
>> cmdline_parts_set(parts, disk_size, state);
>> cmdline_parts_verifier(1, state);
>
>> -
>> - seq_buf_puts(&state->pp_buf, "\n");
>> -
>> + seq_buf_putc(&state->pp_buf, '\n');
>
> Why did you remove blank lines?
>
>> return 1;
I imagine that this source code place can become a bit more succinct.
See also:
efi_partition()
https://elixir.bootlin.com/linux/v7.1.1/source/block/partitions/efi.c#L694-L756
Do you insist to preserve two blank lines here?
Regards,
Markus