Re: [PATCH v1 3/3] arm64: dts: qcom: x1e78100-t14s: Add thermal zones for keyboard skin and charging sensors

[Daniel Lezcano]

On 6/25/26 13:36, Konrad Dybcio wrote:
> On 6/24/26 11:08 PM, Daniel Lezcano wrote:
> > Add thermal zone descriptions for the keyboard skin temperature and
> > battery charging circuitry sensors exposed by the embedded controller.
> >
> > Expose the EC as a thermal sensor provider and define two thermal zones
> > using the temperatures reported by the EC:
> >
> >    - a keyboard skin temperature zone with passive and hot trip points,
> >    - a charging circuitry temperature zone with multiple passive trip
> >      points and CPU frequency mitigation levels.
> >
> > The charging thermal zone progressively throttles the different CPU
> > clusters as the charging circuitry temperature rises and triggers a hot
> > condition at the highest trip point.
> >
> > This provides thermal framework integration for the EC temperature
> > sensors and enables platform thermal management through standard thermal
> > zone definitions.
> >
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxxxxxxxx>
> > ---
>
> [...]
>
> > +	ec-charging-thermal {
> > +		polling-delay = <5000>;
> > +		polling-delay-passive = <2000>;
> > +
> > +		thermal-sensors = <&ec 3>;
> > +
> > +		trips {
> > +			psv0: trip-point0 {
>
> "ec_charging_tripN", please - these labels are file-wide, so it's
> better if they're not overly short
>
> > +				temperature = <55000>;
> > +				hysteresis = <0>;
> > +				type = "passive";
> > +			};
> > +
> > +			alert0: trip-point1 {
> > +				temperature = <63000>;
> > +				hysteresis = <0>;
> > +				type = "hot";
> > +			};
> > +		};
> > +
> > +		cooling-maps {
> > +			map0 {
> > +				trip = <&psv0>;
> > +				cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > +						 <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > +						 <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > +						 <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > +						 <&cpu4 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > +						 <&cpu5 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > +						 <&cpu6 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > +						 <&cpu7 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > +						 <&cpu8 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > +						 <&cpu9 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > +						 <&cpu10 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > +						 <&cpu11 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
> > +
> > +			};
>
> Stray \n above, might also possibly want to throttle the GPU.

At this point, I don't think GPU throttling is needed