Re: [PATCH v2 1/3] dt-bindings: media: qcom: Add JPEG encoder binding

[Atanas Filipov]

On 6/25/2026 4:55 PM, Krzysztof Kozlowski wrote:
> On 25/06/2026 15:38, Atanas Filipov wrote:
> > Add device-tree binding for the Qualcomm JPEG encoder hardware block
> > present in SM8250 (Kona) SoCs.
> >
> > The JPEG encoder is a standalone hardware IP within the camera subsystem
> > that performs JPEG compression in memory-to-memory fashion.  It is
> > separate from the CAMSS ISP pipeline and has its own register space,
> > interrupt, clocks, power domain, IOMMU streams, and interconnect paths.
> >
> > Properties documented:
> > - compatible: qcom,sm8250-jenc
> > - reg / reg-names: single MMIO region named "jpeg"
> > - interrupts: single edge-triggered interrupt
> > - clocks / clock-names: Common clocks and JPEG core clock
> > - power-domains: TITAN_TOP_GDSC common domain
> > - iommus: two SMMU stream IDs for JPEG pixel and JPEG DMA processing
> > - interconnects / interconnect-names
> > - OPP table mapping performance levels to clock frequencies
>
> Drop, since when commits have such text? Why are you describing diff?
>
>
> > Signed-off-by: Atanas Filipov <atanas.filipov@xxxxxxxxxxxxxxxx>
> > ---
> >   .../bindings/media/qcom,jpeg-encoder.yaml     | 135 ++++++++++++++++++
> >   1 file changed, 135 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml
> > new file mode 100644
> > index 000000000000..ab8d8951d21f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml
>
> Nothing improved.
>
> You actually ignored all the comments from me and at least one more
> comment from other emails provided to you.
>
> This is not acceptable.
>
> NAK
>
>
> Best regards,
> Krzysztof

Hi Krzysztof,

You are right, I apologize. I missed several comments.

I will address them properly in v3.

Regards,
Atanas