Re: [PATCH v1 1/1] ocp: Add I2C control support for Adva TimeCard

[Andrew Lunn]

On Thu, Jun 25, 2026 at 04:38:02PM +0300, Sagi Maimon wrote:
> - Load i2c-dev module to expose /dev/i2c-N character devices
> - Add sysfs-based I2C bus control for Adva TimeCard model

A list like this suggests the patch should actually be two patches.
Also, the commit message should answer the question "Why?". I can see
what you have done by reading the patch. But Why have you done it?

> +	request_module("i2c-dev");

linux/drivers$ grep -r i2c-dev | grep request
grep: i2c/i2c-dev.o: binary file matches

No other drive does this. Why is this driver special?

    Andrew

---
pw-bot: cr