Re: [PATCH] USB: serial: digi_acceleport: fix write buffer corruption

[Greg Kroah-Hartman]

On Tue, Jun 23, 2026 at 05:12:29PM +0200, Johan Hovold wrote:
> The digi_write_inb_command() is supposed to wait for the write urb to
> become available or return an error, but instead it updates the transfer
> buffer and tries to resubmit the urb on timeout.
> 
> To make things worse, for commands like break control where no timeout
> is used, the driver would corrupt the urb immediately due to a broken
> jiffies comparison (on 32-bit machines this takes five minutes of uptime
> to trigger due to INITIAL_JIFFIES).
> 
> Fix this by adding the missing return on timeout and waiting
> indefinitely when no timeout has been specified as intended.
> 
> This issue was (sort of) flagged by Sashiko when reviewing an unrelated
> change to the driver.
> 
> Link: https://sashiko.dev/#/patchset/20260610132232.356139-1-johan%40kernel.org?part=11
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>