Re: [PATCH v2 2/3] arm64: dts: qcom: sm8250: Add JPEG encoder node

[Bryan O'Donoghue]

On 25/06/2026 14:38, Atanas Filipov wrote:
> +		qcom_jpeg_enc: jpeg-encoder@ac53000 {
> +			compatible = "qcom,sm8250-jenc";
> +
> +			reg = <0 0xac53000 0 0x1000>;
> +
> +			interrupts = <GIC_SPI 474 IRQ_TYPE_EDGE_RISING>;
> +			power-domains = <&camcc TITAN_TOP_GDSC>;

MXC is still missing from this list.

It cannot simultaneously be the case that jpeg-enc is a standalone block 
but also relies on other things to scale MXC.

Take the example of MDSS and Iris here in sm8850.dtsi.
> +
>   		camss: camss@ac6a000 {

I'm sympathetic to using jpeg-enc without having to load/enable CAMSS 
however, I keep coming back to

- CamNoc
  jpeng-enc relies on a dedicted camera NoC exclusive to the rest of the
  SoC
- jpeg-enc lives in the TITAN_TOP_GDSC power-island which wrappers
  the whole camera block that jpeg lives in

To me those are just two examples of why things within that block should 
be grouped together in DT and effectively look like a bus. There are 
probably more examples. That is a function of the fact all of these 
blocks live within the one power-island, have their own NoC with their 
own input/output ports in that NoC.

They are designed to work together. Yes jpeg-enc _can_ be used outside 
of Camera but, it is designed as part of that block and we will continue 
to find dependencies as we go.

So again please structure this as a sub-node.

---
bod