Re: [PATCH 1/2] bpf: preserve rx_queue_index across XDP redirects

[Mehdi Ben Hadj Khelifa]

On 6/25/26 5:44 PM, Alexei Starovoitov wrote:
> On Wed Jun 24, 2026 at 6:54 PM PDT, Jakub Kicinski wrote:
> > On Sat, 20 Jun 2026 12:13:13 +0000 Siddharth C wrote:
> > > diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c
> > > index 5e59ab896f05..8f2d7013620f 100644
> > > --- a/kernel/bpf/cpumap.c
> > > +++ b/kernel/bpf/cpumap.c
> > > @@ -197,7 +197,7 @@ static int cpu_map_bpf_prog_run_xdp(struct bpf_cpu_map_entry *rcpu,
> > >   
> > >   		rxq.dev = xdpf->dev_rx;
> > >   		rxq.mem.type = xdpf->mem_type;
> > > -		/* TODO: report queue_index to xdp_rxq_info */
> > > +		rxq.queue_index = xdpf->rx_queue_index;
> >
> > Do you actually need this or you're just trying to address the TODO?
>
> It's a 3rd if not 4th attempt from various "people" to address this TODO.
> We should just remove this line instead.

I was one of the people that tried this. And also I have already sent
a patch to address the misleading comment to prevent future wasted 
effort. My patch is still on hold (LINK: 
https://lore.kernel.org/all/20251021114714.1757372-1-mehdi.benhadjkhelifa@xxxxxxxxx/).

Best Regards,
Mehdi Ben Hadj Khelifa