Re: [PATCH v3 1/5] ASoC: intel: sst-mfld-platform-pcm: Use __free(kfree) for stream pointer

[Cezary Rojewski]

On 6/25/2026 12:54 PM, Bui Duc Phuc wrote:
> Hi Cezary,

...

> After re-reading the cleanup.h guidelines,
> I think I was mistaken about suggesting an ordering between the
> __free() and guard() patches.
> Sorry for the confusion.
> Since both conversions are part of the same goto-to-scope-cleanup transition,
> combining them into a single patch seems more appropriate.
> That said, I'm happy to follow your preference.
> Would you prefer a single patch or two separate patches?
Hi Phuc,

Thank you for revisiting your take.  In regard to your question, I'd 
prefer separating __free() from locking.

As a sidenote: even if that my take from technical perspective would be 
a complete miss, the commit message should plainly state: a preparation 
step for upcoming locking changes.  With such statement, a maintainer is 
aware that there is more to the change than just pointers cleanup and 
placing it at the front is intentional.

Kind regards,
Czarek