Re: [PATCH 1/1] mm/shrinker: add NULL checks after rcu_dereference() in shrinker bit functions
From: Muchun Song
Date: Thu Jun 25 2026 - 23:50:13 EST
> On Jun 25, 2026, at 11:01, 傅清爽 <fuqingshuang@xxxxxxxxxx> wrote:
>
> Hi Qi,
>
> Thank you very much for your detailed analysis and patient explanation.
> I fully understand your point that the existing caller constraints guarantee shrinker_info cannot be NULL here, and this NULL check is unnecessary defensive code.
Thanks for your contribution! I have a couple of quick suggestions to
help things go smoother:
- Please take a closer look at our community communication guidelines,
as we rely on plain-text-based replies here.
- For any issues you're not completely sure about, it would be awesome
if you could run a quick validation yourself before sending out a patch.
Maintainers' time is quite limited, so this helps everyone save a lot
of energy and speeds up the review process.
Thanks for understanding, and looking forward to your next patch!
Thanks,
Muchun