Re: [PATCH v3] gpio: mvebu: fail probe if gpiochip registration fails

[Bartosz Golaszewski]

On Wed, 24 Jun 2026 15:16:45 +0200, Pengpeng Hou <pengpeng@xxxxxxxxxxx> said:
> mvebu_gpio_probe() registers the GPIO chip with
> devm_gpiochip_add_data() but ignores the return value. If registration
> fails, probe continues and leaves later code operating on a GPIO chip
> that was never published to gpiolib.
>
> Return the registration error so the device fails probe cleanly.
>
> Fixes: fefe7b092345 ("gpio: introduce gpio-mvebu driver for Marvell SoCs")
> Signed-off-by: Pengpeng Hou <pengpeng@xxxxxxxxxxx>
> ---
> Changes since v2:
> https://lore.kernel.org/all/20260622153137.69065-1-pengpeng@xxxxxxxxxxx/
> - Add the Fixes tag requested by Bartosz Golaszewski.

Please include the entie changelog with all versions in the future.

Bart

>
>  drivers/gpio/gpio-mvebu.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
> index c030d1f00abc..689dc6354c2d 100644
> --- a/drivers/gpio/gpio-mvebu.c
> +++ b/drivers/gpio/gpio-mvebu.c
> @@ -1221,7 +1221,10 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
>  		BUG();
>  	}
>
> -	devm_gpiochip_add_data(&pdev->dev, &mvchip->chip, mvchip);
> +	err = devm_gpiochip_add_data(&pdev->dev, &mvchip->chip, mvchip);
> +	if (err)
> +		return dev_err_probe(&pdev->dev, err,
> +				     "failed to register gpiochip\n");
>
>  	/* Some MVEBU SoCs have simple PWM support for GPIO lines */
>  	if (IS_REACHABLE(CONFIG_PWM)) {
> --
> 2.50.1 (Apple Git-155)
>
>