RE: [PATCH] Fix possible strscpy() buffer overflows

[Datta, Shubhrajyoti]

> -----Original Message-----
> From: David Laight <david.laight.linux@xxxxxxxxx>
> Sent: Tuesday, May 12, 2026 12:46 AM
> To: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Andrei Purdea <andrei@xxxxxxxxx>; Datta, Shubhrajyoti
> <shubhrajyoti.datta@xxxxxxx>; Geraldo Nascimento
> <geraldogabriel@xxxxxxxxx>; Alexander A. Klimov
> <grandmaster@xxxxxxxxxxxx>; Tony Luck <tony.luck@xxxxxxxxx>; Kees Cook
> <kees@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; Nick Li <nick.li@xxxxxxxxxxxx>; Liam
> Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>;
> Jaroslav Kysela <perex@xxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; linux-
> edac@xxxxxxxxxxxxxxx; Linux Kernel Mailing List <linux-
> kernel@xxxxxxxxxxxxxxx>; linux-sound@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] Fix possible strscpy() buffer overflows
> 

...
> 
> It would be better if amd_rpmsg_id_table[] were 'const' - in that case the
> strscpy() call should 'degenerate' into a memcpy().

Here the channel is error_ipc 
So instead of copying we can initialize the name.

diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c
index 18284c76651c..161bde2b14ba 100644
--- a/drivers/edac/versalnet_edac.c
+++ b/drivers/edac/versalnet_edac.c
@@ -720,14 +720,14 @@ MODULE_DEVICE_TABLE(rpmsg, amd_rpmsg_id_table);

 static int rpmsg_probe(struct rpmsg_device *rpdev)
 {
-       struct rpmsg_channel_info chinfo;
        struct mc_priv *pg;
+       struct rpmsg_channel_info chinfo = {
+               .src = RPMSG_ADDR_ANY,
+               .dst = rpdev->dst,
+               .name = "error_ipc",
+       };

        pg = (struct mc_priv *)amd_rpmsg_id_table[0].driver_data;
-       chinfo.src = RPMSG_ADDR_ANY;
-       chinfo.dst = rpdev->dst;
-       strscpy(chinfo.name, amd_rpmsg_id_table[0].name,
-               strlen(amd_rpmsg_id_table[0].name));

        pg->ept = rpmsg_create_ept(rpdev, rpmsg_cb, NULL, chinfo);
        if (!pg->ept)
> 
> -- David
> 
> 
> >
> > In case someone goes and changes that amd_rpmsg_id_table[0].name in
> > the future.
> >