Re: [PATCH] fix: net: mediatek: mtk_star_mdio_init: fix double of_node_put after devm_of_mdiobus_register

[Andrew Lunn]

On Fri, Jun 26, 2026 at 11:20:09PM +0800, WenTao Liang wrote:
> After devm_of_mdiobus_register succeeds, the mdio_node reference
>   ownership is transferred to the mii_bus device (released via
>   mdiobus_release on device teardown). However, the function
>   unconditionally calls of_node_put(mdio_node) after registration, causing
>   a double put.
> 
> Only call of_node_put when devm_of_mdiobus_register fails (i.e., when
>   ownership was not transferred). On success, the bus driver manages the
>   reference lifecycle.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 9ed0a3fac08b ("net: ethernet: mtk-star-emac: use devm_of_mdiobus_register()")
> Signed-off-by: WenTao Liang <vulab@xxxxxxxxxxx>


    Andrew

---
pw-bot: cr