Re: [PATCH] fix: net: ti: cpsw_probe_dt: fix phy_node reference leak on error paths

[Andrew Lunn]

On Fri, Jun 26, 2026 at 11:29:06PM +0800, WenTao Liang wrote:
> After slave_data->phy_node is assigned (via of_node_get or
>   of_parse_phandle), if subsequent calls like of_get_phy_mode or
>   ti_cm_get_macid fail, the error path jumps to err_node_put which only
>   releases the loop's port_np reference but not the phy_node reference.
>   This causes a device_node reference leak.
> 
> Release slave_data->phy_node via of_node_put before jumping to
>   err_node_put on error paths after phy_node has been acquired.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: ed3525eda4c4 ("net: ethernet: ti: introduce cpsw switchdev based driver part 1 - dual-emac")
> Signed-off-by: WenTao Liang <vulab@xxxxxxxxxxx>


    Andrew

---
pw-bot: cr