Re: [PATCH v2 2/2] media: arm: mali-c55: Add support for RGB Gamma
From: Linus Walleij
Date: Fri Jun 26 2026 - 13:31:06 EST
Hi Jacopo,
On Fri, Jun 26, 2026 at 4:52 PM Jacopo Mondi
<jacopo.mondi@xxxxxxxxxxxxxxxx> wrote:
> > > #define MALI_C55_REG_GAMMA_OFFSETS_1 0x1c070
> > > #define MALI_C55_GAMMA_OFFSET_R_MASK GENMASK(11, 0)
> > > #define MALI_C55_GAMMA_OFFSET_G_MASK GENMASK(27, 16)
> >
> > Same here *GAMMA_OFFSETS_RG
>
> Aren't the R and G masks different ?
>
> Or are you suggesting
> #define MALI_C55_REG_GAMMA_OFFSETS_RG 0x1c070
Yes, exactly, then when reading I know "aha that register contains
R and G gamma".
Yours,
Linus Walleij