Re: [PATCH v2 4/6] mm/page_owner: add missing newline to count_threshold format string

From: Zi Yan

Date: Fri Jun 26 2026 - 14:53:48 EST


On Thu Jun 25, 2026 at 10:45 PM EDT, Ye Liu wrote:
> The DEFINE_SIMPLE_ATTRIBUTE format string for page_owner_threshold_fops
> is missing a trailing \n. simple_attr_read() uses scnprintf() with the
> format string, which does not append a newline, so reading
> /sys/kernel/debug/page_owner_stacks/count_threshold produces output
> without a terminating newline. Add the missing \n to match the
> standard debugfs attribute convention.
>
> Signed-off-by: Ye Liu <ye.liu@xxxxxxxxx>
> ---
> mm/page_owner.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

LGTM.

Reviewed-by: Zi Yan <ziy@xxxxxxxxxx>



--
Best Regards,
Yan, Zi