Re: [PATCH v2 10/13] fork: Store task pointer in unpopulated stack ptes

From: Thomas Gleixner

Date: Fri Jun 26 2026 - 18:46:45 EST


On Fri, Apr 24 2026 at 12:14, David Stevens wrote:
> Store the task pointer in the ptes of the unpopulated pages of dynamic
> stacks, to allow the vm_struct pointer to be retrieved without relying
> on any locks or current.

You fail to explain why you can't use current. Changelogs have to
describe the WHY and not the WHAT.

>
> -bool is_vmalloc_addr(const void *x)
> +noinstr bool is_vmalloc_addr(const void *x)
> {
> unsigned long addr = (unsigned long)kasan_reset_tag(x);

noinstr is not enough here unless this depends on !KASAN because
kasan_reset_tag() is a 'static inline' which CLANG happily puts out of
line into the instrumentable section...