[PATCH] drm/amd/display: Remove redundant NULL check before kfree in mod_power_create()
From: Ziran Zhang
Date: Sat Jun 27 2026 - 05:37:26 EST
kfree() safely handles NULL pointers, so there is no need to check for
NULL before calling kfree().
Remove redundant NULL check.
Found by Coccinelle ifnullfree script.
Signed-off-by: Ziran Zhang <zhangcoder@xxxxxxxx>
---
drivers/gpu/drm/amd/display/modules/power/power.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/modules/power/power.c b/drivers/gpu/drm/amd/display/modules/power/power.c
index 5659a38b3..74d5530de 100644
--- a/drivers/gpu/drm/amd/display/modules/power/power.c
+++ b/drivers/gpu/drm/amd/display/modules/power/power.c
@@ -270,12 +270,10 @@ struct mod_power *mod_power_create(struct dc *dc,
fail_bad_brightness_range:
fail_alloc_backlight_array:
for (inst = 0; inst < edp_num; inst++)
- if (core_power->bl_prop[inst].backlight_lut)
- kfree(core_power->bl_prop[inst].backlight_lut);
+ kfree(core_power->bl_prop[inst].backlight_lut);
fail_construct:
for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++) {
- if (core_power->map[i].psr_context)
- kfree(core_power->map[i].psr_context);
+ kfree(core_power->map[i].psr_context);
}
kfree(core_power->map);
@@ -295,8 +293,7 @@ void mod_power_destroy(struct mod_power *mod_power)
MOD_POWER_TO_CORE(mod_power);
for (i = 0; i < MOD_POWER_MAX_CONCURRENT_STREAMS; i++)
- if (core_power->map[i].psr_context)
- kfree(core_power->map[i].psr_context);
+ kfree(core_power->map[i].psr_context);
for (i = 0; i < core_power->num_entities; i++)
if (core_power->map[i].stream)
@@ -305,8 +302,7 @@ void mod_power_destroy(struct mod_power *mod_power)
kfree(core_power->map);
for (i = 0; i < MAX_NUM_EDP; i++)
- if (core_power->bl_prop[i].backlight_lut)
- kfree(core_power->bl_prop[i].backlight_lut);
+ kfree(core_power->bl_prop[i].backlight_lut);
kfree(core_power);
}
--
2.43.0