[PATCH] iio: adc: ad7779: Initialize completion before requesting IRQ
From: Moksh Panicker
Date: Sat Jun 27 2026 - 07:22:34 EST
init_completion() is called after devm_request_irq() in
ad7779_setup_trigger(). If the IRQ fires before init_completion()
runs, the completion is in an undefined state.
Move init_completion() before devm_request_irq() to ensure the
completion is ready before the IRQ handler can signal it.
Fixes: c9a3f8c7bfcb ("drivers: iio: adc: add support for ad777x family")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Moksh Panicker <mokshpanicker.7@xxxxxxxxx>
---
drivers/iio/adc/ad7779.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/adc/ad7779.c b/drivers/iio/adc/ad7779.c
index 695cc79e78da..db8f5f4c6d6a 100644
--- a/drivers/iio/adc/ad7779.c
+++ b/drivers/iio/adc/ad7779.c
@@ -838,6 +838,8 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev
st->trig->ops = &ad7779_trigger_ops;
iio_trigger_set_drvdata(st->trig, st);
+ init_completion(&st->completion);
+
ret = devm_request_irq(dev, st->spi->irq, iio_trigger_generic_data_rdy_poll,
IRQF_NO_THREAD | IRQF_NO_AUTOEN, indio_dev->name,
@@ -852,8 +854,6 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev
indio_dev->trig = iio_trigger_get(st->trig);
- init_completion(&st->completion);
-
ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
&iio_pollfunc_store_time,
&ad7779_trigger_handler,
--
2.34.1