Re: [PATCH v3 05/10] KVM: x86/xen: Consolidate checks on Xen vCPU ID for singleshot timer hypercalls

[David Woodhouse]

On Fri, 2026-06-26 at 11:12 -0700, Sean Christopherson wrote:
> 
> I disagree.  The old code uses a common check for kvm_xen_timer_enabled(), which
> is confusing and actively dangerous, as evidenced by my goof, because it's easy
> to miss that the only reason KVM can bail early for !kvm_xen_timer_enabled() is
> because it returns false.  Punting hypercalls that are never accelerated by KVM
> because some other hypercall happens to be disabled is nasty.

Fair enough. Go ahead then.

Attachment: smime.p7s
Description: S/MIME cryptographic signature